Skip to content

Correctly handle randomizing of Seed.Recursive modifications #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Markoutte
Copy link
Collaborator

Description

Fixes #1990

When fuzzer fails to generate any fields of an object, the object was set to null. To fix this now null-this values are ignored. Also, there's a non-optimal logic, when fuzzer try to fuzz values of modified fields first and only then choose a subset of those modifications. With this patch fuzzer choose subset of modifications in Seed.Recursive and only then will fuzz them.

How to test

Automated tests

All fuzzer tests should pass.

Manual tests

Try an example from the issue. It should generate at least 1 trivial test.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@Markoutte Markoutte added ctg-bug Issue is a bug comp-fuzzing Issue is related to the fuzzing labels Mar 21, 2023
@Markoutte Markoutte force-pushed the pelevin/1990_IAE_in_Instrumented_process_for_mocks branch from 1689416 to 7a8b22f Compare March 21, 2023 09:20
@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) March 21, 2023 09:41
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit caa44f1 into main Mar 21, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the pelevin/1990_IAE_in_Instrumented_process_for_mocks branch March 21, 2023 09:46
@alisevych alisevych modified the milestone: 2023.03 Release Mar 21, 2023
Vassiliy-Kudryashov pushed a commit that referenced this pull request Mar 21, 2023
Correctly handle randomizing of Seed.Recursive modifications and ignore null-this in Java fuzzing
@alisevych alisevych added this to the 2023.03 Release milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-fuzzing Issue is related to the fuzzing ctg-bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalArgumentExceptions in Instrumented process for MockReturnObjectExample
3 participants